• @jaark@infosec.pub
    link
    fedilink
    English
    792 days ago

    I’m no expert and I know that javascript is full of wtf moments, but please… Let it be B

    It’s not gong to be B, it’s it.

    • It is true. Math.min() returns positive Infinity when called with no arguments and Math.max() returns Negative Infinity when called with no arguments. Positive Infinity > Negative Infinity.

      Math.min() works something like this

      def min(numbers):
        r = Infinity
        for n in numbers:
          if n < r:
            r = n
        return r
      

      I’m guessing there’s a reason they wanted min() to be able to be called without any arguments but I’m sure it isn’t a good one.

      • @timhh@programming.dev
        link
        fedilink
        132 minutes ago

        I’m guessing there’s a reason they wanted min() to be able to be called without any arguments but I’m sure it isn’t a good one.

        It not a totally unreasonable definition. For example it preserves nice properties like min(a.concat(b)) == min([min(a), min(b)]).

        Obviously the correct thing to do is to return an optional type, like Rust does. But … yeah I mean considering the other footguns in Javascript (e.g. the insane implicit type coersion) I’d say they didn’t do too badly here.

      • @bss03@infosec.pub
        link
        fedilink
        English
        342 days ago

        So, the language isn’t compiled (or wasn’t originally) so they couldn’t make min() be an error that only a developer saw, it has to be something that the runtime on the end-user system dealt with. So, it had to be assigned some value. Under those restrictions, it is the most mathematically sound value. It makes miniumum-exactly-2(x, min(<…>)) be exactly the same as min(x, <…>), even when the “<…>” has no values.

        As a developer, I see a lot of value in static analysis, including refusing to generate output for sufficiently erroneous results of static analysis, so I don’t like using JS, and the language that I tinker with will definitely have a separate compilation step and reject the equivalent of min(). But, if I HAD to assign something like that a value, it probably would be a representation of infinity, if we had one (probably will due to IEEE floats).

        HTH

        • @hades@lemm.ee
          link
          fedilink
          91 day ago

          The language not being compiled has nothing to do with error handling. You could have a min function that operates on dynamic arrays (e.g. std::min_element in C++ or min() in Python).

          • @bss03@infosec.pub
            link
            fedilink
            English
            422 hours ago

            Not having a separate compilation step absolutely affects error handling. With a compilation step, you can have errors that will only be seen by and must be address by a developer prior to run time. Without one, the run time system, must assign some semantics to the source code, no matter how erroneous it is.

            No matter what advisory “signature” you imagine for a function, JS has to assign some run time semantics to that function being called incorrectly. Compiled languages do not have to provide a run time semantics to for signatures that can be statically checked.

            • @hades@lemm.ee
              link
              fedilink
              08 hours ago

              I agree, compiled languages prevent large classes of errors, including invoking functions with wrong parameters. However, whether or not you define calling max() with no arguments to be an error or not is unrelated to your language being compiled or interpreted. You could define max() to be -inf in C++ if you wanted, even though the language allows you to prevent invocations of max() with no arguments altogether.

              • @bss03@infosec.pub
                link
                fedilink
                English
                13 hours ago

                The run time still has to assign a semantics to it, even if that semantics is a fatal error. In a compiled language, you can prevent the run time from having to assign any semantics by eliminating the error condition at compile time.

            • @BatmanAoD@programming.dev
              link
              fedilink
              116 hours ago

              Without one, the run time system, must assign some semantics to the source code, no matter how erroneous it is.

              That’s just not true; as the comment above points out, Python also has no separate compilation step and yet it did not adopt this philosophy. Interpeted languages were common before JavaScript; in fact, most LISP variants are interpreted, and LISP is older than C.

              Moreover, even JavaScript does sometimes throw errors, because sometimes code is simply not valid syntactically, or has no valid semantics even in a language as permissive as JavaScript.

              So Eich et al. absolutely could have made more things invalid, despite the risk that end-users would see the resulting error.

              • @bss03@infosec.pub
                link
                fedilink
                English
                115 hours ago

                Python also has no separate compilation step and yet it did not adopt this philosophy

                Yes. It did. It didn’t assign exactly the same semantics, but it DOES assign a run time semantic to min().

                • @BatmanAoD@programming.dev
                  link
                  fedilink
                  3
                  edit-2
                  2 hours ago

                  I’m addressing the bit that I quoted, saying that an interpreted language “must” have valid semantics for all code. I’m not specifically addressing whether or not JavaScript is right in this particular case of min().

                  …but also, what are you talking about? Python throws a type error if you call min() with no argument.

      • Its the min value of the input params, or Infinity.

        And the reason it’s Infinity If there is no input, for better or worse, under the hood the method is assigning a variable, min, the highest value possible and then comparing it to each element in the list, reassigning it when it encounters an element lower than its value at the time. So it will obviously always be reassigned if there are any elements at all (if they’re less than Infinity, I guess). But if there are no elements, it’s never reassigned, and thus returns Infinity. It could have just signed min to the first element instead if Infinity, but that would lead to a runtime error when min was run without a function. If you’re not going to throw a runtime error though, it makes sense for min to return Infinity because, what other number could you return that couldn’t actually be the minimum

      • @wise_pancake@lemmy.ca
        link
        fedilink
        13
        edit-2
        2 days ago

        Math.min.length is 2, which weakly signals that it’s designed to handle at least two parameters

        Why would they even define this value?

        Note: I’m not a js dev, do most functions have length?

        • @bss03@infosec.pub
          link
          fedilink
          English
          1
          edit-2
          21 hours ago

          All functions built with function name(args) { body } syntax have a length based on the form of args. Other ways to create functions might set length (I’m not sure). Most of the functions provided by the runtime environment do have a length, usually based on the number of “required” arguments.

    • @sp3ctr4l@lemmy.dbzer0.com
      link
      fedilink
      English
      11
      edit-2
      2 days ago

      I also am not familiar with javascript anymore…precisely because of this, exact, insane bullshit.

      B… and/or C… evaluating as FALSE are the only things that… should even kind of make sense, according to my brain.

      Though at this point in my life, I have unironically had a good number of concussions and contusions, so … well you’d think that would help with JS development.

      Javascript is insanity, and I am still convinced it is at least 40% responsible for Notch losing his goddamned mind.

      ‘null’ is somehow an object. because fuck you, thats why!

      Is… 0 == ‘’ … is that two single quotes ’ ’ ?

      Or one double quote " ?

      If… it is one double quote… that wouldn’t even evaluate, as it would just be an empty string without a defined end…

      But if it was two single quotes… that would just be a proper empty string… and because of forced type coercion, both 0 and ‘’ are FALSE when compared with ==, but not when compared with ===, because that ignores forced type coercion…

      https://www.w3docs.com/snippets/javascript/when-to-use-double-or-single-quotes-in-javascript.html

      Oh my fucking god WHY?!

      Just fucking use one special character to delimit strings!

      Don’t have two that don’t work together and also behave differently even when you pick just one of them… GraaaghhH!

      brb, figuring out where Larry Ellison lives…

      • @jaark@infosec.pub
        link
        fedilink
        English
        5
        edit-2
        1 day ago

        I don’t think my sanity can take all of these explanations.

        Though I just spotted one that’s worse than null being an object …

        typeof NaN
        "number"
        

        I mean, come on… it’s even in the fucking name!

        Edit - fixed capitalisation in ‘NaN’

        • lad
          link
          fedilink
          English
          31 day ago

          That’s just short for JavaScript, isn’t it?

          • Zos_Kia
            link
            fedilink
            31 day ago

            Java is actually twice faster cause the name is twice shorter

      • @traches@sh.itjust.works
        link
        fedilink
        English
        21 day ago

        It’s pretty easy to avoid all of these, mostly by using ===. Null being an object is annoying and is one of the reasons ‘typeof’ is useless, but there are other ways to accomplish the same thing.

        JavaScript has a lot of foot guns, but it’s also used by literally everyone so there is a lot of tooling and practice to help you avoid them.